Change LocalStack of batches from global to client-local in storage #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
This was referenced Jul 14, 2015
Merged
|
Will do |
dhermes
force-pushed
the
storage-move-stack-to-client
branch
from
be75a35 to
8a64306
Compare
|
@tseaver Rebased |
| @@ -291,7 +291,7 @@ def download_to_file(self, file_obj, client=None): | |||
| headers['Range'] = 'bytes=0-%d' % (self.chunk_size - 1,) | |||
| request = http_wrapper.Request(download_url, 'GET', headers) | |||
|
|
|||
| download.InitializeDownload(request, client.connection.http) | |||
| download.InitializeDownload(request, client._connection.http) | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This is to allow seamless switching between the stored connection and the active batch. Also undoing hack in storage system test since batches are supported correctly now on clients.
Doing this to address review commits. Also testing current() in the presence of an empty batch stack.
dhermes
force-pushed
the
storage-move-stack-to-client
branch
from
8a64306 to
7112533
Compare
|
@tseaver I addressed 2 of the 3 comments and responded to the third (slightly changed a bit). |
|
I can let the "real client" bit go, I guess. LGTM |
|
Thanks! |
dhermes
added a commit
that referenced
this pull request
Jul 21, 2015
Change LocalStack of batches from global to client-local in storage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Has #989 as diffbase